Nullreferenceexception in az accounts#10292#10303
Merged
isra-fel merged 30 commits intoAzure:masterfrom Mar 10, 2020
Merged
Conversation
… change is for Get-AzTenant
… to avoid NullReferenceException
…protential null reference
…to nullreferenceexception-in-AzAccounts#10292
…to nullreferenceexception-in-AzAccounts#10292
…to nullreferenceexception-in-AzAccounts#10292
…xcept ListTenants
Collaborator
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
markcowl
previously requested changes
Oct 24, 2019
Member
markcowl
left a comment
markcowl
left a comment
There was a problem hiding this comment.
Yabo, this looks great. It would be nice to have some regression protection for this issue - let's discuss what to do about tests
tools/RunVersionController.ps1
Outdated
| $_.FullName -notlike "*dll-Help.psd1*" -and ` | ||
| $_.FullName -notlike "*Stack*" } } | ||
|
|
||
Member
There was a problem hiding this comment.
Looks like some added whitespace here
| [Parameter(ParameterSetName = ResourceGroupParameterSet, Mandatory = false, HelpMessage = "Display Default Resource Group", ValueFromPipelineByPropertyName = true)] | ||
| public SwitchParameter ResourceGroup { get; set; } | ||
|
|
||
| protected override IAzureContext DefaultContext |
Member
There was a problem hiding this comment.
Is is possible to add tests for these? It would be nice to not regress on these in the future.
Collaborator
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
The null-ref issues might be fixed by MSAL code. Will verify that when #9982 is merged |
isra-fel
dismissed
markcowl’s stale review
Discussed with Yabo; it's hard to mock auth-related stuff when testing
Member
|
Fix #10292 |
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
…in-AzAccounts#10292 Nullreferenceexception in az accounts#10292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #10292
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added